-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Answer Details in Assessment Statistics Page (Part 3: Past Answers View) #7135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bivanalhar
force-pushed
the
bivan/teacher-stats-past-answer-3
branch
2 times, most recently
from
February 25, 2024 10:13
805a1e7
to
4437b1d
Compare
ekowidianto
changed the base branch from
master
to
bivan/teacher-stats-past-answer-2
March 4, 2024 11:46
bivanalhar
force-pushed
the
bivan/teacher-stats-past-answer-3
branch
from
March 14, 2024 03:43
f667c56
to
7450188
Compare
bivanalhar
force-pushed
the
bivan/teacher-stats-past-answer-2
branch
from
March 14, 2024 03:50
934f775
to
9e9c7a7
Compare
bivanalhar
force-pushed
the
bivan/teacher-stats-past-answer-3
branch
from
March 14, 2024 03:51
7450188
to
fe946a0
Compare
bivanalhar
force-pushed
the
bivan/teacher-stats-past-answer-2
branch
11 times, most recently
from
August 1, 2024 14:23
4bd0a0d
to
3826bba
Compare
bivanalhar
force-pushed
the
bivan/teacher-stats-past-answer-3
branch
2 times, most recently
from
August 2, 2024 03:38
740ada9
to
a0c15c2
Compare
bivanalhar
force-pushed
the
bivan/teacher-stats-past-answer-3
branch
4 times, most recently
from
August 2, 2024 06:10
b1de151
to
b9b86f0
Compare
bivanalhar
force-pushed
the
bivan/teacher-stats-past-answer-2
branch
from
August 23, 2024 04:26
3826bba
to
6c76d87
Compare
bivanalhar
force-pushed
the
bivan/teacher-stats-past-answer-3
branch
from
August 23, 2024 04:28
b9b86f0
to
a5fb2db
Compare
- per submission question id
- split pages for answerDisplay between attemptCount and marksPerQuestion - create URL for past answers - workflow state chip clickable to submission edit page - className for using tailwind color for workflow state chip
- provide link to past answers and also submission edit page in answer box and past answer page - Slider to show timeline of answers (from earliest to most recent one) - add comment component into answer box and past answer
cysjonathan
force-pushed
the
bivan/teacher-stats-past-answer-3
branch
from
September 5, 2024 17:32
7e60baf
to
1ff4c7d
Compare
cysjonathan
requested changes
Sep 5, 2024
...pp/bundles/course/assessment/pages/AssessmentStatistics/AnswerDisplay/AllAttemptsDisplay.tsx
Outdated
Show resolved
Hide resolved
...pp/bundles/course/assessment/pages/AssessmentStatistics/AnswerDisplay/AllAttemptsDisplay.tsx
Outdated
Show resolved
Hide resolved
...pp/bundles/course/assessment/pages/AssessmentStatistics/AnswerDisplay/AllAttemptsDisplay.tsx
Show resolved
Hide resolved
...pp/bundles/course/assessment/pages/AssessmentStatistics/AnswerDisplay/AllAttemptsDisplay.tsx
Outdated
Show resolved
Hide resolved
client/app/bundles/course/assessment/submission/pages/QuestionIndex/PastAttempts.tsx
Outdated
Show resolved
Hide resolved
...pp/bundles/course/assessment/pages/AssessmentStatistics/AnswerDisplay/AllAttemptsDisplay.tsx
Show resolved
Hide resolved
bivanalhar
force-pushed
the
bivan/teacher-stats-past-answer-3
branch
3 times, most recently
from
September 6, 2024 04:14
c3792f6
to
550768a
Compare
- differentiate between all passed, some passed and none passed - give more information for how many test cases passed - fix all indentation and formatting error in BE code
- test for API call question_answer_details - and also all_answers
- for Answer Details, need to use 'lg' to display annotated comments as well
- after annotation is loaded, set into Redux to reduce prop drilling
- per submission question id
- split pages for answerDisplay between attemptCount and marksPerQuestion - create URL for past answers - workflow state chip clickable to submission edit page - className for using tailwind color for workflow state chip
- provide link to past answers and also submission edit page in answer box and past answer page - Slider to show timeline of answers (from earliest to most recent one) - add comment component into answer box and past answer
bivanalhar
force-pushed
the
bivan/teacher-stats-past-answer-3
branch
4 times, most recently
from
September 9, 2024 09:42
81e05f9
to
442e8f7
Compare
cysjonathan
reviewed
Sep 9, 2024
...nt/app/bundles/course/assessment/pages/AssessmentStatistics/StudentMarksPerQuestionTable.tsx
Outdated
Show resolved
Hide resolved
- add TODO for sliders - show total grade only for graded / published
- bump tanstack table to the last stable version (8.16.0) - in the updated version, we can set up the priority for undefined
bivanalhar
force-pushed
the
bivan/teacher-stats-past-answer-3
branch
from
September 9, 2024 10:57
442e8f7
to
0159eb0
Compare
cysjonathan
approved these changes
Sep 9, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This is the continuation of the previous PR #7131 that completes the whole component of this Teacher Statistics by having past attempts also displayed in the answer box, should the user navigate to see the answer box from Attempt Count table in Assessment Statistics.
Other than that, the Comment component is also added on all the Answer Box, to give user the holistic view on the answer and how the interaction between graders and students occur regarding that mentioned answer.
This PR is related with the issue #4567
Features Added
When navigating to Answer box from Attempt Count Table, user will see the following:
The slider represents the timeline of the student's attempt. For the answer box, we limit the number of past answers that can be viewed up to 10, and there shall be a link provided on the bottom of this Answer Box to allow user to see all the past answers, which will be provided on the new Page.. some additional note, is that we also provide the comments view for each answer view, should the answer has some comments posted.
Other than that, on top of both the answer box and also past answers view, we also have the link that provides user access to the Submission Edit Page. If the page is tabbed, user will be directed to the exact question it appears, otherwise user will just be directed to its Submission Page (the whole questions in one page)